[Maypole] Re: Non-insignificant add/update issues

Jesse Sheidlower jester@panix.com
Mon, 1 Mar 2004 12:00:52 -0500


On Mon, Mar 01, 2004 at 03:39:04PM +0000, Simon Cozens wrote:
> Jesse Sheidlower wrote:
> (Maybe we should be using the list, for Maypole discussions, to archive
> this sort of thing for posterity.)

(Makes sense.)

> Well, you shouldn't need to, but I think we need to avoid or redefine
> "moniker" so that it uses the same rules as CDBI::Loader.

'Twould be a good idea.

> > When I try to add a new anything (not just a user), Maypole dies
> > with a "Can't use an undefined value as an ARRAY reference at...
> > CDBI.pm line 38", this being the line in do_edit that goes
> >   my ($obj) = @{$r->objects};
> 
> It doesn't go like that in CVS. :) 

You're right. Upgrading to the CVS version has fixed this problem.
Thanks.

> > I'm also getting weirdness when I try to edit an entry. Simply,
> > the entry does not update. I've set up untaint_columns and such,
> > and when I do an update, the "warn "Updating an object ($obj)""
> > line of do_edit [which should, I expect, ultimately be pulled,
> > as it's debugging code] 
[...]
> > shows that the correct values are being
> > set for the object. However, the object does not update, and
> > there are no errors shown.
> 
> I've seen this when the untaint columns aren't properly specified,
> but I'm not sure what to do if they are. Can you check that whatever
> is specifying the untaint_columns is actually being called?

I'll have to play around further. It _is_ being called; I know
because I tried a test where I entered invalid values that
should have triggered CGI::Untaint errors, and I managed to
create some kind of endless loop that hung Apache entirely
and I had to restart it :-/

Jesse Sheidlower